fix(native): Advance Velox, Fix FunctionMetadataTest.Greatest

[pratikpugalia]

Summary:
Advance Velox, Update Failing Test

• Added two new function signatures to the Greatest.json file:
  • time, time -> time
  • time, time with tz -> time with tz

Differential Revision: D88100122

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends the FunctionMetadataTest coverage for the greatest function by adding two new time-based overloads in Greatest.json and updating the expected function count in the corresponding C++ unit test.

File-Level Changes

Change	Details	Files
Extend greatest() function metadata tests to cover new time and time with time zone overloads.	Update the greatest() unit test to expect 15 function signatures instead of 13. Add two new greatest() signatures to the JSON metadata: time,time->time and time, time with time zone->time with time zone.	presto-native-execution/presto_cpp/main/functions/tests/FunctionMetadataTest.cpp presto-native-execution/presto_cpp/main/functions/tests/data/Greatest.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider replacing the hard-coded expected count 15 in testFunction("greatest", ...) with a value derived from the Greatest.json contents (or a shared constant) to avoid having to manually update the test whenever new signatures are added.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider replacing the hard-coded expected count `15` in `testFunction("greatest", ...)` with a value derived from the `Greatest.json` contents (or a shared constant) to avoid having to manually update the test whenever new signatures are added.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[aditi-pandit]

Thanks @pratikpugalia

[pramodsatya]

Thanks @pratikpugalia. The test is still failing in the CI, could you please fix it?
Also, please change the commit message naming to follow conventional commit format.

cc: @amitkdutta

[pratikpugalia]

@pramodsatya @aditi-pandit @amitkdutta

Changed description and fixed the test by advancing velox but seeing some unrelated maven failures!

[aditi-pandit]

Thanks @pratikpugalia

[pramodsatya]

Thanks @pratikpugalia.