Skip to content

Fix error classification for array with null elements #25187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zhiying12
Copy link

Description
Presto does not support array comparison with null elements. Previously, it was classified as internal InvalidFunctionArgumentException. It is converted as a user error by using PrestoException.

Motivation and Context
This unsupported operation was misclassified, resulting in inaccuracies.

Impact
No impact.

Test Plan
CREATE TABLE my_table (
id INTEGER,
names ARRAY(VARCHAR)
);
SELECT * FROM my_table where names = array[NULL];

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@Zhiying12 Zhiying12 requested a review from a team as a code owner May 23, 2025 17:28
@Zhiying12 Zhiying12 requested a review from ZacBlanco May 23, 2025 17:28
Copy link
Collaborator

@kewang1024 kewang1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also append the test result in the summary, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants