Skip to content

Fail query runner when nodes do not come up #25184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Fail query runner when nodes do not come up #25184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 44 additions & 15 deletions presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
import java.util.Optional;
import java.util.Set;
import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicReference;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReadWriteLock;
Expand Down Expand Up @@ -362,14 +363,15 @@ private DistributedQueryRunner(
}
prestoClients = prestoClientsBuilder.build();

long start = nanoTime();
while (!allNodesGloballyVisible()) {
Assertions.assertLessThan(nanosSince(start), new Duration(100, SECONDS));
MILLISECONDS.sleep(10);
try {
waitForAllNodesGloballyVisible();
}
catch (TimeoutException e) {
closer.close();
throw e;
}
log.info("Announced servers in %s", nanosSince(start).convertToMostSuccinctTimeUnit());

start = nanoTime();
long start = nanoTime();
for (TestingPrestoServer server : servers) {
server.getMetadata().registerBuiltInFunctions(AbstractTestQueries.CUSTOM_FUNCTIONS);
}
Expand Down Expand Up @@ -517,22 +519,49 @@ else if (coordinatorSidecar) {
return server;
}

private boolean allNodesGloballyVisible()
private void waitForAllNodesGloballyVisible()
throws Exception
{
int expectedActiveNodesForRm = externalWorkers.size() + servers.size();
int expectedActiveNodesForCoordinator = externalWorkers.size() + servers.size();
long startTimeInMs = nanoTime();
int expectedActiveNodes = externalWorkers.size() + servers.size();
Duration timeout = new Duration(100, SECONDS);

for (TestingPrestoServer server : servers) {
for (int serverIndex = 0; serverIndex < servers.size(); ) {
TestingPrestoServer server = servers.get(serverIndex);
AllNodes allNodes = server.refreshNodes();
int activeNodeCount = allNodes.getActiveNodes().size();

if (!allNodes.getInactiveNodes().isEmpty() ||
(server.isCoordinator() && activeNodeCount != expectedActiveNodesForCoordinator) ||
(server.isResourceManager() && activeNodeCount != expectedActiveNodesForRm)) {
return false;
if (!allNodes.getInactiveNodes().isEmpty()) {
throwTimeoutIfNotReady(
startTimeInMs,
timeout,
format("Timed out waiting for all nodes to be globally visible. Inactive nodes: %s", allNodes.getInactiveNodes()));
MILLISECONDS.sleep(10);
serverIndex = 0;
}
else if ((server.isCoordinator() || server.isResourceManager()) && activeNodeCount != expectedActiveNodes) {
throwTimeoutIfNotReady(
startTimeInMs,
timeout,
format("Timed out waiting for all nodes to be globally visible. Node count: %s, expected: %s", activeNodeCount, expectedActiveNodes));
MILLISECONDS.sleep(10);
serverIndex = 0;
}
else {
log.info("Server %s has %s active nodes", server.getBaseUrl(), activeNodeCount);
serverIndex++;
}
}
return true;

log.info("Announced servers in %s", nanosSince(startTimeInMs).convertToMostSuccinctTimeUnit());
}

private static void throwTimeoutIfNotReady(long startTimeInMs, Duration timeout, String message)
throws TimeoutException
{
if (nanosSince(startTimeInMs).compareTo(timeout) >= 0) {
throw new TimeoutException(message);
}
}

public TestingPrestoClient getRandomClient()
Expand Down
Loading