Skip to content

[DNR] Test for first pr. #25181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[DNR] Test for first pr. #25181

wants to merge 2 commits into from

Conversation

KIRITOLTR
Copy link

Description

Adding some simple examples for functions in aggregate.rst.

Motivation and Context

For addressing the lack of working examples in functions docs. See #19830

Impact

Documentation.

Test Plan

Local doc builds. Some Screeshot:
c0e67e3d-ed4f-464e-a43d-bab573d93372

badbf4f8-6129-498e-8560-cd50d5eb617a

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== NO RELEASE NOTE ==

Copy link

linux-foundation-easycla bot commented May 23, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@KIRITOLTR
Copy link
Author

Hi, @steveburnett. Seems like there is a building problem in presto-docs module. How to solve this check failure for now? Referrence here #25178.

@steveburnett
Copy link
Contributor

Hi, @steveburnett. Seems like there is a building problem in presto-docs module. How to solve this check failure for now? Referrence here #25178.

Fix has been merged, and the test is now passing - see #25188 for an example. Rebase your PR to re-run the CI tests and docs / test (:presto-docs) (pull_request) should pass for this PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 Unprioritized
Development

Successfully merging this pull request may close these issues.

2 participants