[native] Fail-fast for file formats unsupported by hive connector #25147
+35
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
sh-shamsan and
pdabre12
and removed request for
a team
pramodsatya
requested review from
tdcmeehan,
aditi-pandit,
a team and
nishithakbhaskaran
and removed request for
sh-shamsan,
pdabre12 and
a team
tdcmeehan
reviewed
May 20, 2025
| if (connectorSystemConfig.isNativeExecution()) { | ||
| StorageFormat storageFormat = table.getStorage().getStorageFormat(); | ||
| Optional<HiveStorageFormat> hiveStorageFormat = getHiveStorageFormat(storageFormat); | ||
| if (hiveStorageFormat.isPresent() && !(hiveStorageFormat.equals(Optional.of(DWRF)) |
There was a problem hiding this comment.
Let's add this in the Hive configs. By default, it is empty, which means whatever is available in Hive is fine. It can be a set of comma separated values.
|
@pramodsatya : Thanks for this code. Should we add a check for the file formats applicable at the Writer side as well ? Native execution only supports DWRF and Parquet writers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presto C++ only supports reading of tables with
DWRF,ORCandPARQUETfile formats with hive connector. Using confignative-execution-enabled, we can fail-fast at coordinator when attempting to read from tables with unsupported file formats in Presto C++.Motivation and Context
Currently attempting to read from tables with unsupported file formats in Presto C++ fails at the worker:
These missing reader factories can be detected at the coordinator itself instead of sending the splits to workers.