Write mapping support #25124
Open
Write mapping support #25124
+1,123
−579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
bibith4 and
NivinCS
and removed request for
a team
infvg
force-pushed
the
write-mapping
branch
4 times, most recently
from
50a7742 to
e7b8684
Compare
infvg
force-pushed
the
write-mapping
branch
8 times, most recently
from
b03db2f to
de13a86
Compare
ZacBlanco
reviewed
May 21, 2025
.gitignore
Outdated
| @@ -18,6 +18,7 @@ test-reports/ | |||
| .DS_Store | |||
| .classpath | |||
| .settings | |||
| .java-version | |||
| else if (type.getTypeSignature().getBase().equals(StandardTypes.JSON)) { | ||
| return sliceMapping("jsonb", ((statement, index, value) -> { | ||
| PGobject pgObject = new PGobject(); | ||
| pgObject.setType("json"); | ||
| pgObject.setValue(value.toStringUtf8()); | ||
| statement.setObject(index, pgObject); | ||
| })); | ||
| } | ||
| return super.toWriteMapping(type); |
There was a problem hiding this comment.
It looks like we're also adding support for JSON types here? If so, can the JSON support be in a separate commit?
There was a problem hiding this comment.
I have another PR that will add additional type supports so I'll move it to there
| } | ||
|
|
||
| return super.toSqlType(type); | ||
| else if (type.getTypeSignature().getBase().equals(StandardTypes.JSON)) { |
There was a problem hiding this comment.
Suggested change
| else if (type.getTypeSignature().getBase().equals(StandardTypes.JSON)) { | |
| else if (type.getTypeSignature().getBase().equals(JSON)) { |
|
|
||
| return super.toSqlType(type); | ||
| else if (type.getTypeSignature().getBase().equals(StandardTypes.JSON)) { | ||
| return sliceMapping("jsonb", ((statement, index, value) -> { |
There was a problem hiding this comment.
why is this jsonb? Are we able to convert to the binary form for postgres? I think it should be json
infvg
force-pushed
the
write-mapping
branch
2 times, most recently
from
c065212 to
84ded12
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 57a85ce...5f8e951. No notifications. |
Co-authored-by: pratyakshsharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, write mapping is hard coded in JdbcPageSink.appendColumn, making it difficult to add additional write support. This PR adds WriteMapping to match the ReadMapping functionality & make it possible to add additional type support on a per connector basis.
Motivation and Context
It will allow us to support additional types on a per connector basis
Impact
None
Test Plan
Unit tests
Contributor checklist
Release Notes