Skip to content

Add StartWorkingDirectory output to csproj.user file#2679

Open
themorfeus wants to merge 1 commit intopremake:masterfrom
themorfeus:csproj_startworkingdir
Open

Add StartWorkingDirectory output to csproj.user file#2679
themorfeus wants to merge 1 commit intopremake:masterfrom
themorfeus:csproj_startworkingdir

Conversation

@themorfeus
Copy link
Copy Markdown

What does this PR do?

Emits debugdir to StartWorkingDirectory in .csproj.user file
Closes #1339

How does this PR change Premake's behavior?

Premake should now correctly set-up the working directory when starting from within the IDE

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes (n/a, documentation for debugdir already suggests this works)

So not all of them, but can't find any relevant tests to copy from.

Comment on lines +87 to +88
-- Per-configuration reference paths aren't supported (are they?) so just
-- use the first configuration in the project
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was copied from the above function unchanged. If this still applies can you update the comment, otherwise it would be good to have this work like debugargs where it can be specified per config.

Copy link
Copy Markdown
Member

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C#: debugdir does not set working directory

3 participants