feat: print [New] or [Updated] in generation output#2672
Open
ak-slongchamps wants to merge 1 commit intopremake:masterfrom
Open
feat: print [New] or [Updated] in generation output#2672ak-slongchamps wants to merge 1 commit intopremake:masterfrom
ak-slongchamps wants to merge 1 commit intopremake:masterfrom
Conversation
nickclark2016
requested changes
Apr 28, 2026
| elseif (f > 0) then | ||
| printf("Generated %s...", path.getrelative(os.getcwd(), fn)) | ||
| if fileexists then | ||
| printf("Generated %s... [Updated]", path.getrelative(_WORKING_DIR, fn)) |
Member
There was a problem hiding this comment.
This feels like we should do this only in the case of the "verbose" flag. If it's not specified, it should be using the original behavior.
Member
There was a problem hiding this comment.
Would also be nice to avoid duplicating the printf so that updating the call doesn't require making the same change in multiple places.
Jarod42
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prints [New] or [Updated] next to the generated files when they have been touched on the filesystem.
How does this PR change Premake's behavior?
Adds extra info to pre-exiting output.
Uses global
_WORKING_DIRinstead of callingos.getcwd()as a minor optimization.Adds a filesystem access to determine if the file existed prior.
Anything else we should know?
Useful to know when files are new vs updated
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!