Skip to content

Show error messages from broken includes #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsinsane merged 3 commits into from
Sep 28, 2024
+22 −8
Merged

Show error messages from broken includes #2264

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6703872
Added context to errors from include()
richard-sim Sep 27, 2024
5238489
Further improvements to error message display for includes
richard-sim Sep 28, 2024
a514ebe
Catch errors executing code loaded from includes
richard-sim Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/base/_foundation.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,13 @@

local res = os.locate(fname, with_ext, p5, p4)
res = res or fname
local compiled_chunk = loadfile(res)
local compiled_chunk, err = loadfile(res)
if compiled_chunk == nil then
premake.error("Cannot find either " .. table.implode({fname, with_ext, p5, p4}, "", "", " or "))
if err then
Comment thread
samsinsane marked this conversation as resolved.
Outdated
premake.error("Cannot load " .. fname .. ": " .. err)
else
premake.error("Cannot find either " .. table.implode({fname, with_ext, p5, p4}, "", "", " or "))
end
end
return res, compiled_chunk
end
Expand Down