fix: save glob-root for correct rebuilds #4839
Conversation
tdejager
changed the title
| /// E.g we are building from `package.build.source.path = "../"` we want | ||
| /// to resolve globs from that location | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub glob_root: Option<PathBuf>, |
There was a problem hiding this comment.
This is the new field.
| alias = "source_code_root", | ||
| alias = "input_root" | ||
| )] | ||
| pub glob_root: Option<PathBuf>, |
| return Ok(Some(metadata)); | ||
| }; | ||
|
|
||
| let Some(cached_root) = metadata.glob_root.as_ref() else { |
There was a problem hiding this comment.
Here we regenerate if its not found.
| .await | ||
| .map_err_with(SourceBuildCacheStatusError::SourceCheckout)?; | ||
|
|
||
| let Some(glob_root) = source_info.glob_root.as_ref().cloned() else { |
I assumed that we would only bump this if we were to make a breaking change in the |
|
@tdejager and I further discussed the version bump of the metadata cache, and we agreed that we should indeed bump it and then make the |
|
Now that I'm thinking about it, I feel this is not the correct approach, because we should have the data available, we also have it in the discovery code, so I need to close this for now. I might need: #4446 actually first? @remimimimimi lets discuss. |
4 participants
This should fix: #4837
We now save the
glob-root, so where need to start globbing for the file for changes. We save this in the metadata cache, this does invalidate the current entries though, we could also opt to version it to v-2. Wdyt?The test-suite change is here: prefix-dev/pixi-build-testsuite#91