Skip to content

Conversation

lucascolley
Copy link
Collaborator

@lucascolley lucascolley commented Sep 3, 2025

This PR includes necessary fixes to make pixi global install --path /path/to/.conda work, across test cases for absolute paths and various forms of relative paths. It also adds an error message for passing path-like args to pixi global install without passing --path, with a helpful error message.

It also checks that pixi global update and pixi global sync seem to work correctly following such installations.

@lucascolley lucascolley added enhancement New features area:global Related to pixi global labels Sep 5, 2025
@lucascolley
Copy link
Collaborator Author

the first part of the test is passing for me locally, we just need to make it generic over platforms and copy what is necessary to the temporary directory for CI, I think.

For the second part of the test, if we want to disallow direct installation of .conda files without --path, we need to add some check to be hit from

} else {
self.specs
.iter()
.map(|spec_str| {
pixi_global::project::GlobalSpec::try_from_str(spec_str, channel_config)
.map_err(Box::new)
.map_err(GlobalSpecsConversionError::FromMatchSpec)
})
.collect()
}
.


I'll continue with this when Julian is back next week.

@lucascolley lucascolley linked an issue Sep 9, 2025 that may be closed by this pull request
@lucascolley lucascolley marked this pull request as ready for review September 23, 2025 14:13
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lucas!

@lucascolley lucascolley marked this pull request as draft September 23, 2025 15:16
@lucascolley lucascolley marked this pull request as ready for review September 24, 2025 13:06
Comment on lines +1349 to 1351
// XXX: broken
// currently this is always the default so just use the other value
channel_config: other.channel_config,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the lack of merging here leads to a pretty fragile set of fixes in this PR. Implementing a proper merge function so that with_cli_config behaves itself would probably be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:global Related to pixi global enhancement New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(global): direct conda file installation support
3 participants