-
Notifications
You must be signed in to change notification settings - Fork 351
feat(global): direct .conda
installation
#4502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
the first part of the test is passing for me locally, we just need to make it generic over platforms and copy what is necessary to the temporary directory for CI, I think. For the second part of the test, if we want to disallow direct installation of pixi/crates/pixi_cli/src/global/global_specs.rs Lines 116 to 125 in a15e2fa
I'll continue with this when Julian is back next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Lucas!
// XXX: broken | ||
// currently this is always the default so just use the other value | ||
channel_config: other.channel_config, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the lack of merging here leads to a pretty fragile set of fixes in this PR. Implementing a proper merge function so that with_cli_config
behaves itself would probably be nice.
This PR includes necessary fixes to make
pixi global install --path /path/to/.conda
work, across test cases for absolute paths and various forms of relative paths. It also adds an error message for passing path-like args topixi global install
without passing--path
, with a helpful error message.It also checks that
pixi global update
andpixi global sync
seem to work correctly following such installations.