-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.13 #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to have support for Py3.13. in my project
Updating PyO3 involves more than simply changing the version numbers, as it requires additional steps. You can find more details here: https://pyo3.rs/main/migration |
@jvdd - I've made the relevant changes required to properly migrate from PyO3 |
CodSpeed Performance ReportMerging #78 will degrade performances by 41.57%Comparing 🎉 Hooray!
|
Benchmark | main |
my1e5:python3_13 |
Change | |
---|---|---|---|---|
❌ | test_m4_no_x[True-float32-100-100,000] |
408.5 µs | 498.4 µs | -18.03% |
❌ | test_m4_no_x[True-float32-5,000-100,000] |
589 µs | 665.8 µs | -11.53% |
❌ | test_m4_no_x[True-int32-100-100,000] |
556.1 µs | 639.9 µs | -13.1% |
⚡ | test_m4_with_x[True-float32-1,000-100,000] |
1.8 ms | 1.4 ms | +28.87% |
⚡ | test_m4_with_x[True-float32-100-100,000] |
825.7 µs | 745.3 µs | +10.79% |
❌ | test_m4_with_x[True-int64-1,000-100,000] |
1.7 ms | 2.3 ms | -26.56% |
⚡ | test_minmax_no_x[False-float32-100-100,000] |
1,584.9 µs | 885.4 µs | +79% |
❌ | test_minmax_no_x[True-float32-5,000-100,000] |
716.5 µs | 830.2 µs | -13.7% |
⚡ | test_minmax_no_x[True-int32-100-100,000] |
637.3 µs | 553.9 µs | +15.06% |
❌ | test_minmax_with_x[True-float64-1,000-100,000] |
2.2 ms | 2.8 ms | -22.47% |
❌ | test_minmax_with_x[True-int32-1,000-100,000] |
1.6 ms | 2.1 ms | -23.69% |
❌ | test_minmaxlttb_no_x[True-float64-1,000-100,000] |
1.1 ms | 1.2 ms | -10.86% |
❌ | test_minmaxlttb_with_x[True-float32-100-100,000] |
989.8 µs | 1,693.8 µs | -41.57% |
❌ | test_minmaxlttb_with_x[True-float64-100-100,000] |
1.2 ms | 1.6 ms | -24.23% |
❌ | test_minmaxlttb_with_x[True-int32-100-1,000,000] |
3.1 ms | 4.1 ms | -24.51% |
❌ | test_minmaxlttb_with_x[True-int64-1,000-100,000] |
4.5 ms | 5.3 ms | -16.09% |
❌ | test_nanm4_no_x[True-int64-100-100,000] |
802.9 µs | 926.4 µs | -13.33% |
❌ | test_nanm4_with_x[True-float64-1,000-100,000] |
1.6 ms | 1.9 ms | -17.13% |
⚡ | test_nanm4_with_x[True-int32-1,000-1,000,000] |
4.2 ms | 3.5 ms | +19.78% |
❌ | test_nanm4_with_x[True-int32-1,000-100,000] |
1.5 ms | 1.8 ms | -15.56% |
... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Looks good to me! Great work @my1e5 🤝 |
Closes #77