Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #78

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Add support for Python 3.13 #78

merged 4 commits into from
Jan 2, 2025

Conversation

my1e5
Copy link
Contributor

@my1e5 my1e5 commented Oct 11, 2024

Closes #77

Copy link

@Wecros Wecros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to have support for Py3.13. in my project

@jvdd
Copy link
Member

jvdd commented Nov 28, 2024

Updating PyO3 involves more than simply changing the version numbers, as it requires additional steps.

You can find more details here: https://pyo3.rs/main/migration

@my1e5
Copy link
Contributor Author

my1e5 commented Jan 2, 2025

@jvdd - I've made the relevant changes required to properly migrate from PyO3 0.20 to 0.22. I've tested the workflows on my fork and everything seems to be passing.

Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #78 will degrade performances by 41.57%

Comparing my1e5:python3_13 (b3f83b5) with main (05334d5)

🎉 Hooray! pytest-codspeed just leveled up to 3.1.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 9 improvements
❌ 23 regressions
✅ 646 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main my1e5:python3_13 Change
test_m4_no_x[True-float32-100-100,000] 408.5 µs 498.4 µs -18.03%
test_m4_no_x[True-float32-5,000-100,000] 589 µs 665.8 µs -11.53%
test_m4_no_x[True-int32-100-100,000] 556.1 µs 639.9 µs -13.1%
test_m4_with_x[True-float32-1,000-100,000] 1.8 ms 1.4 ms +28.87%
test_m4_with_x[True-float32-100-100,000] 825.7 µs 745.3 µs +10.79%
test_m4_with_x[True-int64-1,000-100,000] 1.7 ms 2.3 ms -26.56%
test_minmax_no_x[False-float32-100-100,000] 1,584.9 µs 885.4 µs +79%
test_minmax_no_x[True-float32-5,000-100,000] 716.5 µs 830.2 µs -13.7%
test_minmax_no_x[True-int32-100-100,000] 637.3 µs 553.9 µs +15.06%
test_minmax_with_x[True-float64-1,000-100,000] 2.2 ms 2.8 ms -22.47%
test_minmax_with_x[True-int32-1,000-100,000] 1.6 ms 2.1 ms -23.69%
test_minmaxlttb_no_x[True-float64-1,000-100,000] 1.1 ms 1.2 ms -10.86%
test_minmaxlttb_with_x[True-float32-100-100,000] 989.8 µs 1,693.8 µs -41.57%
test_minmaxlttb_with_x[True-float64-100-100,000] 1.2 ms 1.6 ms -24.23%
test_minmaxlttb_with_x[True-int32-100-1,000,000] 3.1 ms 4.1 ms -24.51%
test_minmaxlttb_with_x[True-int64-1,000-100,000] 4.5 ms 5.3 ms -16.09%
test_nanm4_no_x[True-int64-100-100,000] 802.9 µs 926.4 µs -13.33%
test_nanm4_with_x[True-float64-1,000-100,000] 1.6 ms 1.9 ms -17.13%
test_nanm4_with_x[True-int32-1,000-1,000,000] 4.2 ms 3.5 ms +19.78%
test_nanm4_with_x[True-int32-1,000-100,000] 1.5 ms 1.8 ms -15.56%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@jvdd
Copy link
Member

jvdd commented Jan 2, 2025

Looks good to me! Great work @my1e5 🤝

@jvdd jvdd merged commit cd68c99 into predict-idlab:main Jan 2, 2025
42 of 44 checks passed
@my1e5 my1e5 deleted the python3_13 branch January 3, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.13
3 participants