Skip to content

Contents of the system tests archive #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 tasks done
MakisH opened this issue Nov 19, 2023 · 2 comments · May be fixed by #629
Open
4 tasks done

Contents of the system tests archive #400

MakisH opened this issue Nov 19, 2023 · 2 comments · May be fixed by #629
Labels
enhancement systemtests

Comments

@MakisH
Copy link
Member

MakisH commented Nov 19, 2023 •
edited by valentin-seitz
Loading

Example of the contents of an archive:

Screenshot from 2023-11-19 21-48-16

I think we still need some changes:

  • reference_results and reference-data seems to be confusing (which is what?). One of them needs to be renamed, maybe to results_to_compare.
  • What is the tutorials_ref? It currently contains master, but in that job, I had asked for develop (see Cannot checkout tutorials develop in tests #399).
  • The actual git commits of each repository are not reported anywhere. See Report git hash of each repository #401
  • Do we need the metadata.yaml, docker-compose.tutorial.yaml, and docker-compose.field_compare.yaml? Are they only useful for debugging the system tests themselves? I would suggest to either delete them, or move them to a subfolder (e.g., system-tests-debug).

cc @valentin-seitz
@MakisH MakisH mentioned this issue Nov 19, 2023
Closed
@MakisH MakisH changed the title System tests: Contents of the archive Contents of the system tests archive Nov 19, 2023
@valentin-seitz
Copy link
Contributor

valentin-seitz commented Nov 25, 2023 •
edited
Loading 

* [ ]  Do we need the `metadata.yaml`, `docker-compose.tutorial.yaml`, and `docker-compose.field_compare.yaml`? Are they only useful for debugging the system tests themselves? I would suggest to either delete them, or move them to a subfolder (e.g., `system-tests-debug`).

One of the big benefits of using containers is, that its very easy to "debug" a problem with a precice component, without having to install all of them manually. So having the docker-compose.tutorial.yaml and the fieldcompare.yaml is a crucial step in reproducing the failed pipeline in your local machine. So i would def. keep them around. A related Issue is: #387 where we need to move some absolute paths into relative ones to allow this "debug the pipeline in your local machine" feature.

@MakisH
Copy link
Member Author

MakisH commented Nov 27, 2023

Then, let's focus on what is currently not included (or how it is named), and remove stuff later.

@MakisH MakisH mentioned this issue Dec 14, 2023
Merged
This was referenced Feb 21, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement systemtests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup the contents of the system tests archives precice/tutorials
2 participants
@MakisH @valentin-seitz