Update preciceDict to comply with upcoming schema changes #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new preCICE schema will have additional options for fields, to specify
solver_name
andoperation
. This means that readData and writeData in preciceDict would be dictionaries instead of lists, so that these additional options can be parsed. For example:I tried to look into ways to keep backwards compatibility with the lists, but this may not be desirable. The new schema warrants breaking changes. In order to read old config files, we'd have to check if it's a list or a dict. OpenFOAM does not make this easy... I tried to use the
ITstream
(Input Token Stream) to check whether the token is(
for list or{
for dict. However theITstream & dictionary.lookup(word &keyword)
works only if i'm looking up a list and not a dict. I would need to write a custom parser. Similar issue on cfd-online forums.TODO list:
docs/
changelog-entries/
(create directory if missing)