New PBS-Java module: optable-targeting #5931
Open
+298
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
…ds -> user.eids (as server converts user.ext.eids to user.eids according to OpenRTB 2.6)
bretg
reviewed
Apr 2, 2025
There was a problem hiding this comment.
The text is fine - thanks for being thorough. However, I have a problem with the design of this module. I strongly dislike that it slows every auction for a WAN call, and that WAN endpoint is global to the account. This is a recipe for performance problems.
I would like you to consider an alternate configuration design where:
- the host company can link your regional endpoints to their own datacenters. e.g. I want to point to your US endpoint in the US, your EU endpoint in the EU, etc.
- any account-level data is appended to this host-level URL
Further, I'd like to request that you consider making use of the local Prebid Cache to store data for ~24 hours. WAN calls are likely to be much slower than local cache calls.
|
Hi @bretg, thank you for the review! We'll work on addressing these design issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optable-targeting module enriches an incoming OpenRTB request by adding to the user.ext.eids and user.ext.data objects. Under the hood the module extracts PPIDs (publisher provided IDs) from the incoming request's user.ext.eids, and also if provided sha256-hashed email, sha256-hashed phone, zip or Optable Visitor ID provided correspondingly in the user.ext.optable.email, .phone, .zip, .vid fields. These IDs are sent as input to the Targeting API. The received response data is used to enrich the OpenRTB request and response. Targeting API endpoint is configurable per publisher.
🏷 Type of documentation
📋 Checklist