Skip to content

Zeta Global SSP: Add sid parameter and audio support, no longer generic #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 19, 2025
Merged

Zeta Global SSP: Add sid parameter and audio support, no longer generic #3865

merged 6 commits into from
May 19, 2025

Conversation

przemkaczmarek
Copy link
Collaborator

@przemkaczmarek przemkaczmarek commented Mar 25, 2025 •
edited by osulzhenko
Loading

🔧 Type of changes

  • bid adapter update

✨ What's the context?

#3818

@AntoxaAntoxic AntoxaAntoxic linked an issue Mar 27, 2025 that may be closed by this pull request
Port PR from PBS-Go: Zeta Global SSP: Add sid parameter and audio support #3818
Closed
AntoxaAntoxic
AntoxaAntoxic requested changes Mar 27, 2025
View reviewed changes
CTMBNara
CTMBNara requested changes Apr 24, 2025
View reviewed changes
src/test/java/org/prebid/server/bidder/zeta_global_ssp/ZetaGlobalSspBidderTest.java Outdated
Comment on lines 146 to 151
final Bid bid = Bid.builder().impid("imp1").ext(mapper.createObjectNode()).build();
final BidderCall<BidRequest> httpCall = givenHttpCall(mapper.writeValueAsString(BidResponse.builder()
.cur("USD")
.seatbid(singletonList(SeatBid.builder().bid(List.of(bid)).build()))
.build()));

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add givenBidResponse and givenBid methods

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you need to use this methods

@CTMBNara
Copy link
Collaborator

#3865 (comment)

@osulzhenko osulzhenko requested a review from CTMBNara April 25, 2025 09:42
CTMBNara
CTMBNara requested changes Apr 25, 2025
View reviewed changes
src/test/java/org/prebid/server/bidder/zeta_global_ssp/ZetaGlobalSspBidderTest.java Outdated
Comment on lines 78 to 81
assertThat(result.getValue()).hasSize(1);
final HttpRequest<BidRequest> httpRequest = result.getValue().getFirst();

assertThat(httpRequest.getUri()).isEqualTo("https://test-url.com/11");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this lines

src/test/java/org/prebid/server/bidder/zeta_global_ssp/ZetaGlobalSspBidderTest.java Outdated
Comment on lines 146 to 151
final Bid bid = Bid.builder().impid("imp1").ext(mapper.createObjectNode()).build();
final BidderCall<BidRequest> httpCall = givenHttpCall(mapper.writeValueAsString(BidResponse.builder()
.cur("USD")
.seatbid(singletonList(SeatBid.builder().bid(List.of(bid)).build()))
.build()));

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you need to use this methods

@osulzhenko osulzhenko requested a review from CTMBNara May 9, 2025 08:06
CTMBNara
CTMBNara requested changes May 15, 2025
View reviewed changes
@CTMBNara CTMBNara merged commit 159efa6 into master May 19, 2025
7 of 8 checks passed
@CTMBNara CTMBNara deleted the Zeta-Global-SSP-Add-sid-parameter-and-audio-support-#3818 branch May 19, 2025 11:33
osulzhenko added a commit that referenced this pull request May 20, 2025
@osulzhenko
Revert "Zeta Global SSP: Add sid parameter and audio support, no long…
8afa313 
…er generic (#3865)"

This reverts commit 159efa6.
@osulzhenko osulzhenko mentioned this pull request May 20, 2025
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CTMBNara CTMBNara CTMBNara approved these changes

@AntoxaAntoxic AntoxaAntoxic AntoxaAntoxic approved these changes

@osulzhenko osulzhenko osulzhenko approved these changes

Assignees

@przemkaczmarek przemkaczmarek

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Zeta Global SSP: Add sid parameter and audio support
4 participants
@przemkaczmarek @CTMBNara @AntoxaAntoxic @osulzhenko