fix: Only run Vite plugin on J/TSX files #537
Conversation
|
| @@ -19,7 +19,7 @@ module.exports = function prefreshPlugin(options = {}) { | |||
| : options && options.ssr === true; | |||
| if ( | |||
| shouldSkip || | |||
| !/\.(t|j)sx?$/.test(id) || | |||
| !/\.(t|j)sx$/.test(id) || | |||
There was a problem hiding this comment.
This is a bit dangerous for custom-hook files as those aren't jsx but js
There was a problem hiding this comment.
I was worried about that. A better check is in order then, I'll need to figure that out.
|
Closing, I have no plans to figure this out but hopefully the linked context is useful enough (assuming there is something for us to fix) |
Fixes vitejs/vite#15262, I think. Need to check yet. Would also need to land in preset-vite, as we form a similar regex there and pass it in to the Prefresh plugin, but thought I'd address it here first.
Now, I'm not quite sure if this breaks anything... is there any need for Prefresh to run in
.jsor.tsfiles? Custom hooks? Dunno, unfortunately I'm not super familiar with how Prefresh actually facilitates HMR.FWIW, this was the regex pattern in use (more or less) until #42, at which point it changed to the form we have now. I don't see any obvious context to it, so it might've just been a (relatively harmless in all fairness) accidental change?