Allow for Context as JSX #4618
Merged
Allow for Context as JSX #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: +1 B (0%) Total Size: 62.4 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
allow-for-context-as-jsx
branch
from
bcb933b to
1006fd9
Compare
JoviDeCroock
requested review from
developit,
andrewiggins,
marvinhagemeister and
rschristian
JoviDeCroock
commented
Dec 29, 2024
There was a problem hiding this comment.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- compat/src/render.js: Evaluated as low risk
- compat/test/browser/render.test.js: Evaluated as low risk
JoviDeCroock
force-pushed
the
allow-for-context-as-jsx
branch
from
bdc5f94 to
e471217
Compare
JoviDeCroock
force-pushed
the
allow-for-context-as-jsx
branch
from
e471217 to
4163c13
Compare
rschristian
approved these changes
Dec 30, 2024
|
I'm good with this, though I do wonder if we should just implement it in core. import { enqueueRender } from './component';
export let i = 0;
export function createContext(defaultValue) {
/** @type {import('./internal').FunctionComponent} */
function Context(props) {
if (!this.getChildContext) {
/** @type {Set<import('./internal').Component> | null} */
let subs = new Set();
let ctx = {};
ctx[Context._id] = this;
this.getChildContext = () => ctx;
this.componentWillUnmount = () => {
subs = null;
};
this.shouldComponentUpdate = function (_props) {
if (this.props.value !== _props.value) {
subs.forEach((c) => {
c._force = true;
enqueueRender(c);
});
}
};
this.sub = (c) => {
subs.add(c);
let old = c.componentWillUnmount;
c.componentWillUnmount = () => {
if (subs) {
subs.delete(c);
}
if (old) old.call(c);
};
};
}
return props.children;
}
Context._id = '__cC' + i++;
Context._defaultValue = defaultValue;
/** @type {import('./internal').FunctionComponent} */
Context.Consumer = (props, contextValue) => {
return props.children(contextValue);
};
// we could also get rid of _contextRef entirely
Context.Provider = Context._contextRef = Context.Consumer.contextType = Context;
return Context;
} |
|
+1 for core if the snippet @developit provided works |
JoviDeCroock
force-pushed
the
allow-for-context-as-jsx
branch
from
b22f51d to
d310b3a
Compare
|
@developit @marvinhagemeister added the suggestion |
JoviDeCroock
force-pushed
the
allow-for-context-as-jsx
branch
from
d310b3a to
75beb76
Compare
JoviDeCroock
commented
Dec 31, 2024
JoviDeCroock
commented
Jan 7, 2025
JoviDeCroock
commented
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another piece of React 19 functionality where we allow the result of
createContextto act as aProvider.Relates to #4613
Depends on preactjs/preact-devtools#493