Merge branch 'main' into support-react-19

preactjs · Jan 7, 2025 · 5a5e24e · 5a5e24e
2 parents cfd33ae + df1f20d
commit 5a5e24e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/jsx.d.ts b/src/jsx.d.ts
@@ -1096,7 +1096,6 @@ export namespace JSXInternal {
 		| 'feed'
 		| 'figure'
 		| 'form'
-		| 'generic'
 		| 'grid'
 		| 'gridcell'
 		| 'group'

diff --git a/test/ts/dom-attributes-test.tsx b/test/ts/dom-attributes-test.tsx
@@ -34,6 +34,10 @@ const signalValidAriaValues2 = (
 );
 
 const validRole = <div role="button" />;
+// @ts-expect-error We should correctly type aria roles
+const invalidRole = <div role="invalid-role" />;
+// @ts-expect-error We should disallow `generic` as it should not ever be explicitly set
+const invalidRole2 = <div role="generic" />;
 const fallbackRole = <div role="none presentation" />;
 
 const booleanishTest = (