chore: Switch all scripts in pkg.json to use yarn #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
Jan 7, 2025
|
Closing for fc60d50 |
|
oh apologies I didn't look at already opened PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super minor, but was fiddling around with the ecosystem CI and came across this.
As some scripts use
npm run, despite this being a yarn repo, it breaks the passing of flags to commands, e.g.,yarn test:e2e:10 --retries 5wouldn't work as npm strips out the--retriesportion, only passing on the5. The CI here also works around this, duplicating the v10 e2e script just to add the flag it needs.Switching these over to yarn makes more sense and allows for passing of flags nicely.