Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 551: allow helm imagePullSecrets on post-install hook #554

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
fixed templating nil pointer error
Signed-off-by: Tom Billiet <tom.billiet@klarrio.com>
adrian-salazar-klarrio authored and TomBillietKlarrio committed Dec 14, 2023
commit ea48b8c3cef78323bc497d18c49abb9d1a424e52
4 changes: 2 additions & 2 deletions charts/zookeeper/templates/post-install-upgrade-hooks.yaml
Original file line number Diff line number Diff line change
@@ -38,9 +38,9 @@ roleRef:

apiVersion: v1
kind: ServiceAccount
{{- if or .Values.global.imagePullSecrets .Values.serviceAccount.imagePullSecrets }}
{{- if .Values.global.imagePullSecrets }}
imagePullSecrets:
{{- range (default .Values.global.imagePullSecrets .Values.serviceAccount.imagePullSecrets) }}
{{- range .Values.global.imagePullSecrets }}
- name: {{ . }}
{{- end }}
{{- end }}
5 changes: 5 additions & 0 deletions charts/zookeeper/values.yaml
Original file line number Diff line number Diff line change
@@ -8,6 +8,11 @@ image:

triggerRollingRestart: false

global:
# Lists the secrets you need to use to pull zookeeper image from a private registry.
imagePullSecrets: []
# - private-registry-key

domainName:
labels: {}
ports: []