Skip to content

Use lower case for MIME type (optimization) #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use lower case for MIME type (optimization) #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8f9978
Converting mime check to use lower case comparison
szalapi Jan 4, 2024
ad38dda
Merge pull request #1 from szalapi/szalapi-patch-is-valid-mime-type
szalapi Jan 4, 2024
9365c67
Fix MIME checking
szalapi Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,20 @@ const plugin = ({ addFilter, utils }) => {
return mimeTypeGroup === wildcardGroup;
};

const isValidMimeType = (acceptedTypes, userInputType) =>
const isValidMimeType = (acceptedTypes, userInputType) => {

// MIME is case insesitive, so we make sure to compare lower case only
const userInputTypeLowerCased = userInputType.toLowerCase();
acceptedTypes.some(acceptedType => {
// accepted is wildcard mime type
if (/\*$/.test(acceptedType)) {
return mimeTypeMatchesWildCard(userInputType, acceptedType);
return mimeTypeMatchesWildCard(userInputTypeLowerCased, acceptedType);
}

// is normal mime type
return acceptedType === userInputType;
return acceptedType.toLowerCase() === userInputTypeLowerCased;
});
}

const getItemType = (item) => {

Expand Down