Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "freestyle" in multiplayer #31260

Merged
merged 42 commits into from
Feb 4, 2025

Merge branch 'master' into multiplayer-free-style

a93dabd
Select commit
Loading
Failed to load commit list.
Merged

Add support for "freestyle" in multiplayer #31260

Merge branch 'master' into multiplayer-free-style
a93dabd
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Feb 4, 2025 in 0s

2 / 2 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
ppy/osu-web#11760 Completed
ppy/osu-server-spectator#251 Completed
Closes #5578 Incomplete
We might want to contact a designer with spare time (icon designer chan maybe) to get something for this Incomplete
Bonus: also showing freemod when it's enabled Incomplete
In IRL discussion, the proposal is to do this in a follow-up PR to reduce complexity. I'm okay with that as we have a couple of weeks before the next release cycle. Incomplete
GetGameplayRuleset is virtual (and overridden by the multiplayer screen), but also reads from UserRuleset which is expected to be set by the multiplayer screen. Incomplete
UserRuleset sits alongside the existing UserMods, but UserMods is never written to outside RoomSubScreen while UserRuleset is. Incomplete