Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework score token validation #11775

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Jan 8, 2025

Combining hash and ruleset validation in the token model itself. build id stays as is because it's quite a bit more involved.

The way beatmap_hash is passed and validated is rather questionable 👀

Mainly in relation to multiplayer play.
@peppy
Copy link
Member

peppy commented Jan 8, 2025

Is this intended to ease the implementation of freestyle, or related to something else?

@nanaya
Copy link
Collaborator Author

nanaya commented Jan 8, 2025

it's related to the freestyle thing, yes

@notbakaneko notbakaneko self-requested a review January 15, 2025 06:24
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there should be assertions some of the values don't change if the token already exists (because it doesn't make sense for them to change) but that's a different problem

@notbakaneko notbakaneko enabled auto-merge January 15, 2025 10:37
@notbakaneko notbakaneko merged commit 4730893 into ppy:master Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants