Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ship with cosmic sig-like name makes parsing fail #84

Merged

Conversation

ppfeufer
Copy link
Owner

See #82

Description

Fixed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Merging #84 (da84618) into master (604663e) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   47.87%   47.80%   -0.07%     
==========================================
  Files          21       21              
  Lines         633      634       +1     
  Branches       81       81              
==========================================
  Hits          303      303              
- Misses        328      329       +1     
  Partials        2        2              
Files Coverage Δ
aa_intel_tool/parser/module/dscan.py 19.20% <0.00%> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604663e...da84618. Read the comment docs.

@ppfeufer ppfeufer marked this pull request as ready for review April 20, 2024 20:32
@ppfeufer ppfeufer merged commit c9bd100 into master Apr 20, 2024
86 of 88 checks passed
@ppfeufer ppfeufer deleted the bug/ship-with-cosmic-sig-like-name-fails-dscan-parsing branch April 20, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ship with cosmic sig-like name makes parsing fail
1 participant