Use EmptyWideStr constant instead of empty string literal

Accounts.dfm

@@ -163,10 +163,6 @@ object AccountsForm: TAccountsForm
     TabOrder = 0
     object AccountsTab: TTabSheet
       Caption = 'Accounts'
-      ExplicitLeft = 0
-      ExplicitTop = 0
-      ExplicitWidth = 0
-      ExplicitHeight = 0
       DesignSize = (
         483
         447)
@@ -386,10 +382,6 @@ object AccountsForm: TAccountsForm
     object GlobalTab: TTabSheet
       Caption = 'Global settings'
       ImageIndex = 1
-      ExplicitLeft = 0
-      ExplicitTop = 0
-      ExplicitWidth = 0
-      ExplicitHeight = 0
       object CloudMaxFileSizeLabelBytes: TLabel
         Left = 292
         Top = 115
@@ -668,10 +660,6 @@ object AccountsForm: TAccountsForm
     object NetworkTab: TTabSheet
       Caption = 'Network settings'
       ImageIndex = 2
-      ExplicitLeft = 0
-      ExplicitTop = 0
-      ExplicitWidth = 0
-      ExplicitHeight = 0
       object SocketTimeoutLabel: TLabel
         Left = 5
         Top = 11

Accounts.pas

@@ -150,9 +150,9 @@ procedure TAccountsForm.AccountsListClick(Sender: TObject);
 		EncryptFilesCombo.ItemIndex := CASettings.encrypt_files_mode;
 		EncryptFilenamesCB.Checked := CASettings.encrypt_filenames;
 	end else begin
-		AccountNameEdit.Text := '';
-		EmailEdit.Text := '';
-		PasswordEdit.Text := '';
+		AccountNameEdit.Text := EmptyWideStr;
+		EmailEdit.Text := EmptyWideStr;
+		PasswordEdit.Text := EmptyWideStr;
 		UseTCPwdMngrCB.Checked := false;
 	end;
 	PublicAccountCB.OnClick(nil);
@@ -168,7 +168,7 @@ procedure TAccountsForm.ApplyButtonClick(Sender: TObject);
 var
 	CASettings: TAccountSettings;
 begin
-	if (AccountNameEdit.Text = '') then
+	if (AccountNameEdit.Text = EmptyWideStr) then
 		exit();
 	CASettings.name := AccountNameEdit.Text;
 	CASettings.email := EmailEdit.Text;
@@ -187,7 +187,7 @@ procedure TAccountsForm.ApplyButtonClick(Sender: TObject);
 		case self.CryptHandler(FS_CRYPT_SAVE_PASSWORD, PWideChar(CASettings.name), PWideChar(CASettings.password), SizeOf(CASettings.password)) of
 			FS_FILE_OK:
 				begin //TC скушал пароль
-					CASettings.password := '';
+					CASettings.password := EmptyWideStr;
 				end;
 			FS_FILE_NOTSUPPORTED: //нажали отмену на вводе мастер-пароля
 				begin //просто выйдем
@@ -260,8 +260,8 @@ procedure TAccountsForm.ApplySettings;
 		case self.CryptHandler(FS_CRYPT_SAVE_PASSWORD, PWideChar('proxy' + ProxyUserEdit.Text), PWideChar(ProxyPwd.Text), SizeOf(ProxyPwd.Text)) of
 			FS_FILE_OK:
 				begin //TC скушал пароль
-					ProxyPwd.Text := '';
-					SetPluginSettingsValue(SettingsIniFilePath, 'ProxyPassword', '');
+					ProxyPwd.Text := EmptyWideStr;
+					SetPluginSettingsValue(SettingsIniFilePath, 'ProxyPassword', EmptyWideStr);
 				end;
 			FS_FILE_NOTSUPPORTED: //нажали отмену на вводе мастер-пароля
 				begin //просто выйдем
@@ -309,7 +309,7 @@ procedure TAccountsForm.DeleteButtonClick(Sender: TObject);
 
 procedure TAccountsForm.FormActivate(Sender: TObject);
 begin
-	ProxyTCPwdMngrCB.Enabled := ProxyUserEdit.Text <> '';
+	ProxyTCPwdMngrCB.Enabled := ProxyUserEdit.Text <> EmptyWideStr;
 	CenterWindow(self.parentWindow, self.Handle);
 end;
 
@@ -319,7 +319,7 @@ procedure TAccountsForm.FormShow(Sender: TObject);
 	AccountsList.SetFocus;
 	if AccountsList.Items.Count > 0 then
 	begin
-		if (self.SelectedAccount <> '') and (AccountsList.Items.IndexOf(self.SelectedAccount) <> -1) then
+		if (self.SelectedAccount <> EmptyWideStr) and (AccountsList.Items.IndexOf(self.SelectedAccount) <> -1) then
 		begin
 			AccountsList.Selected[AccountsList.Items.IndexOf(self.SelectedAccount)] := true;
 		end else begin
@@ -337,7 +337,7 @@ procedure TAccountsForm.GlobalSettingApplyBTNClick(Sender: TObject);
 
 procedure TAccountsForm.ProxyUserEditChange(Sender: TObject);
 begin
-	ProxyTCPwdMngrCB.Enabled := ProxyUserEdit.Text <> '';
+	ProxyTCPwdMngrCB.Enabled := ProxyUserEdit.Text <> EmptyWideStr;
 end;
 
 procedure TAccountsForm.PublicAccountCBClick(Sender: TObject);
@@ -356,7 +356,7 @@ class procedure TAccountsForm.ShowAccounts(parentWindow: HWND; IniPath, Settings
 		AccountsForm.IniPath := IniPath;
 		AccountsForm.SettingsIniFilePath := SettingsIniFilePath;
 		AccountsForm.CryptHandler := CryptHandler;
-		AccountsForm.SelectedAccount := '';
+		AccountsForm.SelectedAccount := EmptyWideStr;
 		{global settings}
 		AccountsForm.UseDLLFromPluginDir.Checked := GetPluginSettings(SettingsIniFilePath).LoadSSLDLLOnlyFromPluginDir;
 		AccountsForm.PreserveFileTimeCB.Checked := GetPluginSettings(SettingsIniFilePath).PreserveFileTime;
@@ -399,7 +399,7 @@ class procedure TAccountsForm.ShowAccounts(parentWindow: HWND; IniPath, Settings
 		AccountsForm.ShowInvitesFoldersCB.Checked := GetPluginSettings(SettingsIniFilePath).ShowInvitesFolders;
 
 		{global settings}
-		if Account <> '' then
+		if Account <> EmptyWideStr then
 			AccountsForm.SelectedAccount := Account;
 		RegisterHotKey(AccountsForm.Handle, 1, 0, VK_ESCAPE);
 		AccountsForm.OptionPages.ActivePageIndex := 0;

AskEncryptionPasswords.pas

@@ -51,7 +51,7 @@ class function TAskEncryptionPasswordsForm.AskPassword(ParentWindow: HWND; Accou
 				FileNamesPassword := AskEncryptionPasswordsForm.EncryptFilenamesPasswordEdit.Text;
 			end
 			else
-				FileNamesPassword := '';
+				FileNamesPassword := EmptyWideStr;
 
 			UseTCPwdMngr := AskEncryptionPasswordsForm.UseTCPwdMngrCB.Checked;
 		end;

CMLJSON.pas

@@ -322,7 +322,7 @@ function fromJSON_OperationResult(JSON: WideString; var OperationStatus: integer
 				//Log(MSGTYPE_IMPORTANTERROR, 'Can''t parse server answer: ' + JSON); todo
 				exit(CLOUD_ERROR_UNKNOWN);
 			end;
-			if error = '' then
+			if error = EmptyWideStr then
 				error := ((ParserObj.Values['body'] as TJSONObject).Values[nodename] as TJSONObject).Values['error'].Value;
 			if error = 'exists' then
 				exit(CLOUD_ERROR_EXISTS);

CloudMailRu.pas

@@ -211,7 +211,7 @@ function TCloudMailRu.CloudResultToFsResult(CloudResult: integer; OperationStatu
 			end;
 		else
 			begin //что-то неизвестное
-				if (ErrorPrefix <> '') then
+				if (ErrorPrefix <> EmptyWideStr) then
 					Log(LogLevelError, MSGTYPE_IMPORTANTERROR, ErrorPrefix + self.ErrorCodeText(CloudResult) + ' Status: ' + OperationStatus.ToString());
 				exit(FS_FILE_WRITEERROR);
 			end;
@@ -268,7 +268,7 @@ constructor TCloudMailRu.Create(AccountSettings: TAccountSettings; split_file_si
 			self.Socks := TIdSocksInfo.Create();
 			self.Socks.Host := Proxy.Server;
 			self.Socks.Port := Proxy.Port;
-			if Proxy.user <> '' then
+			if Proxy.user <> EmptyWideStr then
 			begin
 				self.Socks.Authentication := saUsernamePassword;
 				self.Socks.Username := Proxy.user;
@@ -296,7 +296,7 @@ constructor TCloudMailRu.Create(AccountSettings: TAccountSettings; split_file_si
 		self.crypt_files := AccountSettings.encrypt_files_mode <> EncryptModeNone;
 		self.crypt_filenames := AccountSettings.encrypt_filenames;
 		self.shard_override := AccountSettings.shard_override;
-		if self.public_account and (self.PUBLIC_URL <> '') then
+		if self.public_account and (self.PUBLIC_URL <> EmptyWideStr) then
 		begin
 			self.public_link := self.PUBLIC_URL;
 			self.PUBLIC_URL := IncludeSlash(self.PUBLIC_URL);
@@ -692,7 +692,7 @@ function TCloudMailRu.getFileRegular(remotePath, localPath: WideString; LogError
 	MemoryStream: TMemoryStream;
 begin
 	Result := FS_FILE_NOTSUPPORTED;
-	if self.Shard = '' then
+	if self.Shard = EmptyWideStr then
 	begin
 		Log(LogLevelDetail, MSGTYPE_DETAILS, 'Current shard is undefined, trying to get one');
 		if self.getShard(self.Shard) then
@@ -760,7 +760,7 @@ function TCloudMailRu.getFileShared(remotePath, localPath: WideString; LogErrors
 	FileStream: TFileStream;
 begin
 	Result := FS_FILE_NOTFOUND;
-	if (self.public_shard = '') or (self.public_download_token = '') then
+	if (self.public_shard = EmptyWideStr) or (self.public_download_token = EmptyWideStr) then
 		exit;
 	try
 		FileStream := TFileStream.Create(GetUNCFilePath(localPath), fmCreate);
@@ -814,7 +814,7 @@ function TCloudMailRu.getShard(var Shard: WideString): Boolean;
 		OperationResult := fromJSON_OperationResult(JSON, OperationStatus);
 		case OperationResult of
 			CLOUD_OPERATION_OK:
-				Result := fromJSON_Shard(JSON, Shard) and (Shard <> '');
+				Result := fromJSON_Shard(JSON, Shard) and (Shard <> EmptyWideStr);
 			else
 				begin
 					Result := false;
@@ -853,9 +853,9 @@ function TCloudMailRu.getSharedToken(): Boolean;
 	Result := self.HTTPGetPage(self.PUBLIC_URL, PageContent, Progress);
 	if Result then
 	begin
-		PageContent := StringReplace(PageContent, #$A, '', [rfReplaceAll]); //так нам проще ковыряться в тексте
-		PageContent := StringReplace(PageContent, #$D, '', [rfReplaceAll]);
-		PageContent := StringReplace(PageContent, #9, '', [rfReplaceAll]);
+		PageContent := StringReplace(PageContent, #$A, EmptyWideStr, [rfReplaceAll]); //так нам проще ковыряться в тексте
+		PageContent := StringReplace(PageContent, #$D, EmptyWideStr, [rfReplaceAll]);
+		PageContent := StringReplace(PageContent, #9, EmptyWideStr, [rfReplaceAll]);
 		if not self.extractPublicTokenFromText(PageContent, self.public_download_token) then //refresh public download token
 		begin
 			Log(LogLevelError, MSGTYPE_IMPORTANTERROR, 'Can''t get public share download token');
@@ -905,7 +905,7 @@ procedure TCloudMailRu.HTTPInit(var HTTP: TIdHTTP; var SSL: TIdSSLIOHandlerSocke
 	begin
 		HTTP.ProxyParams.ProxyServer := self.Proxy.Server;
 		HTTP.ProxyParams.ProxyPort := self.Proxy.Port;
-		if self.Proxy.user <> '' then
+		if self.Proxy.user <> EmptyWideStr then
 		begin
 			HTTP.ProxyParams.BasicAuthentication := true;
 			HTTP.ProxyParams.ProxyUsername := self.Proxy.user;
@@ -923,7 +923,7 @@ procedure TCloudMailRu.HTTPInit(var HTTP: TIdHTTP; var SSL: TIdSSLIOHandlerSocke
 		HTTP.ReadTimeout := self.ConnectTimeout;
 	end;
 	HTTP.Request.UserAgent := 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.57 Safari/537.17/TCWFX(' + PlatformX + ')';
-	HTTP.Request.Connection := '';
+	HTTP.Request.Connection := EmptyWideStr;
 end;
 
 procedure TCloudMailRu.HTTPDestroy(var HTTP: TIdHTTP; var SSL: TIdSSLIOHandlerSocketOpenSSL);
@@ -968,7 +968,7 @@ function TCloudMailRu.HTTPGetPage(URL: WideString; var Answer: WideString; var P
 		end;
 
 	end;
-	Result := Answer <> '';
+	Result := Answer <> EmptyWideStr;
 end;
 
 function TCloudMailRu.HTTPGetFile(URL: WideString; FileStream: TStream; LogErrors: Boolean): integer;
@@ -1056,7 +1056,7 @@ function TCloudMailRu.HTTPPostFile(URL: WideString; FileName: WideString; var An
 		FileStream := TFileStream.Create(FileName, fmOpenRead or fmShareDenyWrite);
 		Cipher.CryptStream(FileStream, MemoryStream);
 		MemoryStream.Position := 0;
-		PostData.AddFormField('file', 'application/octet-stream', '', MemoryStream, FileName);
+		PostData.AddFormField('file', 'application/octet-stream', EmptyWideStr, MemoryStream, FileName);
 		Result := self.HTTPPost(URL, PostData, ResultStream);
 		MemoryStream.free;
 		Cipher.free;
@@ -1335,7 +1335,7 @@ procedure TCloudMailRu.logUserSpaceInfo;
 		if (US.overquota) then
 			QuotaInfo := ' Warning: space quota exhausted!'
 		else
-			QuotaInfo := '';
+			QuotaInfo := EmptyWideStr;
 		Log(LogLevelFileOperation, MSGTYPE_DETAILS, 'Total space: ' + FormatSize(US.total) + ', used: ' + FormatSize(US.used) + ', free: ' + FormatSize(US.total - US.used) + '.' + QuotaInfo);
 	end else begin
 		Log(LogLevelDebug, MSGTYPE_IMPORTANTERROR, 'error: getting user space information for ' + self.user + '@' + self.domain);

FileSplitter.pas

@@ -1,4 +1,4 @@
-unit FileSplitter;
+unit FileSplitter;
 
 interface
 

InviteProperty.pas

@@ -50,7 +50,7 @@ class function TInvitePropertyForm.ShowProperties(parentWindow: HWND; Item: TClo
 		InvitePropertyForm.InviteSizeLB.Caption := FormatSize(Item.size, TYPE_BYTES);
 		InvitePropertyForm.InviteTokenLB.Caption := Item.invite_token;
 		InvitePropertyForm.Caption := AccountName + ' invite: ' + Item.name;
-		if Item.home <> '' then //already mounted item
+		if Item.home <> EmptyWideStr then //already mounted item
 		begin
 			InvitePropertyForm.TokenLB.Caption := 'Mounted as:';
 			InvitePropertyForm.InviteTokenLB.Caption := Item.home;

MRC_Helper.pas

@@ -96,7 +96,7 @@ function Implode(S: TStringList; Delimiter: WideString): WideString;
 var
 	iCount: integer;
 begin
-	Result := '';
+	Result := EmptyWideStr;
 	if (S.Count = 0) then
 		exit;
 	for iCount := 0 to pred(S.Count) do
@@ -176,14 +176,14 @@ function ExtractRealPath(VirtualPath: WideString): TRealPath;
 var
 	List: TStringList;
 begin
-	Result.account := '';
-	Result.path := '';
+	Result.account := EmptyWideStr;
+	Result.path := EmptyWideStr;
 	Result.upDirItem := False;
 	Result.trashDir := False;
 	Result.sharedDir := False;
 	Result.invitesDir := False;
 
-	if VirtualPath = '' then
+	if VirtualPath = EmptyWideStr then
 		exit; //root
 	VirtualPath := Copy(VirtualPath, 2, Length(VirtualPath) - 1);
 
@@ -222,7 +222,7 @@ function ExtractRealPath(VirtualPath: WideString): TRealPath;
 //проверка, находится ли путь внутри аккаунта. ignoreVirtual - не считать виртуальные каталоги облачными
 function inAccount(path: TRealPath; ignoreVirtual: boolean = true): boolean;
 begin
-	Result := path.account <> '';
+	Result := path.account <> EmptyWideStr;
 	if Result and ignoreVirtual then
 		Result := not(path.trashDir or path.sharedDir or path.invitesDir);
 end;
@@ -318,7 +318,7 @@ function UrlEncode(URL: WideString): WideString;
 	UTF8: UTF8String;
 begin
 	UTF8 := UTF8String(URL);
-	Result := '';
+	Result := EmptyWideStr;
 	for I := 1 to Length(UTF8) do
 		if UTF8[I] in ['a' .. 'z', 'A' .. 'Z', '/', '_', '-', '.', '0' .. '9'] then
 			Result := Result + WideString(UTF8[I])
@@ -430,7 +430,7 @@ function ExtractUniversalFileExt(const FileName: string): string;
 	if (I >= 0) and (FileName.Chars[I] = '.') then
 		Result := FileName.Substring(I)
 	else
-		Result := '';
+		Result := EmptyWideStr;
 end;
 
 function ChangePathFileName(const FilePath, NewFileName: WideString): WideString;
@@ -459,7 +459,7 @@ function GetWord(command: WideString; WordIndex: integer = 0): WideString;
 var
 	Exploded: TStringList;
 begin
-	Result := '';
+	Result := EmptyWideStr;
 	Exploded := Explode(command, ' ');
 	if Exploded.Count = 0 then
 		exit;
@@ -512,7 +512,7 @@ function PathToUrl(path: WideString; RestrictEmptyUrl: boolean = true; DoUrlEnco
 	if DoUrlEncode then
 		Result := UrlEncode(Result);
 
-	if (Result = '') and RestrictEmptyUrl then
+	if (Result = EmptyWideStr) and RestrictEmptyUrl then
 		Result := '/';
 end;
 
@@ -631,7 +631,7 @@ function LoadPluginIcon(const path: WideString; identifier: WideString): Hicon;
 function RetryAttemptsToString(Attempt: integer): WideString;
 begin
 	if Attempt < 0 then
-		exit('')
+		exit(EmptyWideStr)
 	else
 		exit(' of ' + Attempt.ToString);
 end;

MailRuCloud.dpr

@@ -1422,7 +1422,6 @@ begin
 	ProxySettings := GetPluginSettings(SettingsIniFilePath).Proxy;
 
 	PasswordManager.GetProxyPassword(ProxySettings);
-	//GetProxyPasswordNow(ProxySettings, @LogHandle, @CryptHandle);
 
 	if ProxySettings.use_tc_password_manager then
 		SetPluginSettingsValue(SettingsIniFilePath, 'ProxyTCPwdMngr', true);

RemoteProperty.dfm

@@ -235,10 +235,6 @@ object PropertyForm: TPropertyForm
     object DescriptionTS: TTabSheet
       Caption = 'Description'
       ImageIndex = 2
-      ExplicitLeft = 0
-      ExplicitTop = 0
-      ExplicitWidth = 0
-      ExplicitHeight = 0
       DesignSize = (
         828
         255)
@@ -293,7 +289,7 @@ object PropertyForm: TPropertyForm
     Left = 740
     Top = 147
     Bitmap = {
-      494C010104008C00D40020002000FFFFFFFFFF10FFFFFFFFFFFFFFFF424D3600
+      494C010104008C00D80020002000FFFFFFFFFF10FFFFFFFFFFFFFFFF424D3600
       0000000000003600000028000000800000004000000001002000000000000080
       0000000000000000000000000000000000000000000000000000000000000000
       0000000000000000000000000000000000000000000000000000000000000000