Skip to content

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Sep 16, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
All the notebooks have to install pypowsybl in a cell, which is quite unusaul

What is the new behavior (if this is a feature change)?
The needed package are in a requirements.txt file instead

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really copy/paste a clean config.yml file over the person install ? (it just erased mine 😶‍🌫️ )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that was already the case before I think, but let's clean this while we're at it! Copying the previous config.yml into a config.old.yml would do?

Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
@flo-dup flo-dup requested a review from HugoKulesza September 26, 2025 14:50
@flo-dup flo-dup merged commit 2af7403 into main Sep 30, 2025
2 checks passed
@flo-dup flo-dup deleted the requirements_file branch September 30, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants