Skip to content

Drift web support #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 12, 2024
Merged

Drift web support #55

merged 8 commits into from
Jul 12, 2024

Conversation

mugikhan
Copy link
Contributor

Work done

  • Import sqlite3_common instead of sqlite3 for web support.

@cahofmeyr cahofmeyr self-requested a review July 10, 2024 20:13
@mugikhan mugikhan requested a review from stevensJourney July 11, 2024 14:51
stevensJourney
stevensJourney approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the tests for web support as well. I'm happy to do that at a later stage.

@mugikhan mugikhan merged commit 9428ad9 into main Jul 12, 2024
6 checks passed
@mugikhan mugikhan deleted the feat/drift-web-support branch July 12, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevensJourney stevensJourney stevensJourney approved these changes

@cahofmeyr cahofmeyr Awaiting requested review from cahofmeyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mugikhan @stevensJourney