HTTP Liveness Probe Stopgap Fix #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 07cfe95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The HTTP liveness probe currently always returns a 400 HTTP response code in the API service mode. This is due to the
touched_atvalue not being updated in the last 10 seconds. Generally, in the API mode, the PowerSync service should be alive if it returned any HTTP response. The logic has been updated to always return 200 if the service has been started in the API mode.The current logic is preserved if the service is started in the UNIFIED mode. The liveness probe will return a 400 HTTP status code if the replicator engine has not updated the last
touched_atvalue in 10 seconds. The replicator loop is most likely stuck if the touched at value has not been updated.The HTTP probes are still not yet functional if the service was started purely in the SYNC mode. Future work will introduce more improvements such as an opt-in HTTP sever for this mode and configurable timeouts.