Remove not necessary joins on powa_statements #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco44
force-pushed
the
remove_unnecessary_IN
branch
from
f0c6914 to
196aa29
Compare
marco44
force-pushed
the
remove_unnecessary_IN
branch
from
196aa29 to
cb5e529
Compare
|
agreed. Those are harmful in the sense that if a new queryid is generated and evicted before a snapshot happens, any associated wait even would then be filtered. This is a really unlikely scenario, and if it does happen the pg_stat_statements overhead is probably so big that just disabling it should double your performance so you won't end up using powa anyway. |
rjuju
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with @rjuju , these IN are not necessary, they may even be harmful.
As they use CPU cycles, let's remove them