Improve powa_wait_sampling_history query #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug: the result is still ok, but it's a performance isuse The left boundary query for powa_base_waitdata_detailed_db on the interval is wrong: the matching interval should be from/from (see other queries that do the same manipulation)
|
I don't think the format errors detected in the CI are yours. I'll have a look tomorrow. |
rjuju
approved these changes
Jan 29, 2025
|
FWIW I had a quick look and didn't see any similar problem in other queries. @pgiraud could the ruff check shows the diff rather than saying "something would be changed"? It's not super useful as is :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug: the result is still ok, but it's a performance issue
The left boundary query for powa_base_waitdata_detailed_db on the interval is wrong: the matching interval should be from/from (see other queries that do the same manipulation). So we're doing twice the full interval of the query, once for nothing (and we redo the comparisons on the unnested records on this large one, which takes lots of cpu)