New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw EOFError when reading from IO #6

Open

djellemah wants to merge 2 commits into potatosalad:develop from djellemah:develop

djellemah commented Mar 22, 2018

I was running into trouble reading multiple terms from an IO. This addresses that problem.

Also, it seemed to me that NotImplementedError was the wrong exception for an incorrect magic byte, so I changed that to ArgumentError.

djellemah added 2 commits

March 22, 2018 09:33


          throw EOFError on end-of-buffer while reading from an IO

e9da42c


          throw ArgumentError rather than NotImplementedError when encountering…

64006ef

… an incorrect magic byte

coveralls commented Mar 22, 2018

Coverage increased (+0.0003%) to 99.61% when pulling 64006ef on djellemah:develop into 7426c99 on potatosalad:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet