Clean up parses to make them more safe#114
Open
Clayell wants to merge 2 commits intopost-kerbin-mining-corporation:masterfrom
Open
Clean up parses to make them more safe#114Clayell wants to merge 2 commits intopost-kerbin-mining-corporation:masterfrom
Clayell wants to merge 2 commits intopost-kerbin-mining-corporation:masterfrom
Conversation
Author
|
Their underlying problem of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Xenon recently reported on the KSP-RO server that their log was being spammed with NREs. This is the result of some unsafe ToString() calls to fields that might not exist. (specifically the one for
KopernicusSolarPanelPowerHandler, but I noticed the same mistakes in other classes)I've cleaned up the Utils TryGetField methods a bit, and made some other spots use TryGetField instead of doing their own thing