refactor: remove get_apps() and usage of undocumented applications API #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Remove the last caller of the undocumented
GET /__api__/applications/from this library.Approach
get_apps()was the only caller of this API, and it was only being used in two places, and only to check whether a content item with a given name already exists. TheGET /__api__/v1/content/API accepts anamequery parameter, so we could swap those to use that.I also deleted the
dashboard_url_chr()function, which oddly was exported, because content items includedashboard_urlin them.Checklist
NEWS.md(referencing the connected issue if necessary)?devtools::document()?