Remove unused code and messages after Public DMPs page removal#1306
Open
momo3404 wants to merge 4 commits intointegrationfrom
Open
Remove unused code and messages after Public DMPs page removal#1306momo3404 wants to merge 4 commits intointegrationfrom
momo3404 wants to merge 4 commits intointegrationfrom
Conversation
- Since the public DMPs page no longer exists, the first message that asks to remove the public plan and the conditional logic that renders it are no longer needed
- The logic for rendering the plan index is no longer necessary, so it is removed and simply replaced with a render for the example DMPs page
Generated by 🚫 Danger |
momo3404
changed the title
Collaborator
|
Given our changes, maybe requests for the "Example DMPs" page should now be handled by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1304 .
Changes proposed in this PR:
plan_indexinpublic_pages_controllerto remove unused code.