Skip to content

Update to gtk-rs 0.14, support mod-tap in backend code, and some code improvements - #87

Merged
ids1024 merged 7 commits into
masterfrom
backend-improvements
Aug 20, 2021
Merged

Update to gtk-rs 0.14, support mod-tap in backend code, and some code improvements#87
ids1024 merged 7 commits into
masterfrom
backend-improvements

Conversation

@ids1024

@ids1024 ids1024 commented Aug 19, 2021

Copy link
Copy Markdown
Member

Update from patched git build of gtk-rs to release 0.14, now that it is released an Ubuntu is packaging Rust 1.51.

This also includes the backend changes from #79, so that the Configurator can load a .json layout containing MT(...) bindings, and export/display like that if the keyboard is programmed with it.

This should have no visible impact on behavior, expect when a mod-tap binding is set from outside the GUI.

@ids1024
ids1024 requested review from a team August 19, 2021 02:33

@leviport leviport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mod-tap keys that I bind with QMK directly do show up, but I imagine we might want to find a different way to represent them when we make them an exposed option. I'm okay with this for now, though.
2021-08-19_15-55

Importing and exporting .json layouts with MT's bound seems to be working nicely.

I did regression tests with Launch, oryp6, and a Nelson arduino, and everything appears to be working as expected.

@ids1024

ids1024 commented Aug 19, 2021

Copy link
Copy Markdown
Member Author

but I imagine we might want to find a different way to represent them when we make them an exposed option

Indeed. This representation seems good for the json format, once properly supported we'll probably want to show it differently.

(And if anyone has ideas for a good way to display it in the UI, but all means comment the suggestion on #79. Because I'm not really sure.)

@ids1024
ids1024 merged commit 38c1c7b into master Aug 20, 2021
@ids1024
ids1024 deleted the backend-improvements branch August 20, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants