Windows 10 theme on Windows - #7
Draft
ids1024 wants to merge 1 commit into
Draft
Conversation
Member
Author
Correction: it crashes when the dll dependencies are vendored in the same directory, but not otherwise. Weird... but hopefully resolvable. |
ids1024
force-pushed
the
GtkHeaderBar_nobuild
branch
from
October 9, 2020 17:53
35ff969 to
3892764
Compare
Member
Author
|
This is fixed by copying |
ids1024
force-pushed
the
GtkHeaderBar_nobuild
branch
from
October 9, 2020 21:13
070477e to
8e3b052
Compare
Merged
ids1024
changed the base branch from
pop-keyboard_focal
to
keyboard-configurator
November 10, 2020 20:25
Closed
ids1024
force-pushed
the
GtkHeaderBar_nobuild
branch
from
November 25, 2020 21:11
8e3b052 to
304f08f
Compare
ids1024
force-pushed
the
GtkHeaderBar_nobuild
branch
from
January 13, 2021 19:40
304f08f to
fedaac8
Compare
ids1024
force-pushed
the
keyboard-configurator
branch
from
February 22, 2021 21:17
da5d625 to
bc789ad
Compare
ids1024
force-pushed
the
keyboard-configurator
branch
from
April 6, 2021 15:45
696c5f2 to
29e912c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to match the design in system76/launch#10. This should also fix the issue I mentioned on #2 where enabling the dark theme on Windows leaves the title bar light colored.
Unfortunately the Keyboard Configurator then simply crashes on Windows. I suppose client-side decoration in Gtk is just broken on Windows currently? Perhaps...
If this can't be fixed we'll have to stick with server-side decoration and adjust the design accordingly.