feat: 'Non-US \' on builtin keyboards - #141
Conversation
|
If using an ISO keyboard with this and after several key presses the system will halt and even the power button is unusable.
|
|
Huh, all this does is set a keycode. I guess something may not be quite right in the EC firmware... What laptop is that with, on what firmware version? |
|
darp6, 2021-07-20_93c2809, but I wonder if it's an issue with upstream, I'll test with an unpatched one |
|
ok, it might just be this darp6; using ansi and iso keyboards after typing a few keys it locks up |
|
Used different laptop and ISO keyboard. If set to UK keyboard the # key works but the 'non-us #' key in either US or UK mode always uses '\' and never the '#' key.
|
|
Hm, but |
|
Okay, I guess that's expected, since the (We really need a UI that can adapt to keyboard layout.) |
'Non-US #' is not listed, since the PS/2 keycode for that is the same as 'Backlash'. The UI around non-US layouts could be improved, but that's already an issue and this at least makes it possible to set this mapping. This does not add the `PAUSE` and `SCROLL_LOCK` keycodes that have been added to EC. At least with `PAUSE`, this is complicated since it won't work on older firmware, and we should probably test for that (#140). Fixes #127.
'Non-US \' is not listed, since the PS/2 keycode for that is the same as 'Backlash'. The UI around non-US layouts could be improved, but that's already an issue and this at least makes it possible to set this mapping.
This does not add the
PAUSEandSCROLL_LOCKkeycodes that have been added to EC. At least withPAUSE, this is complicated since it won't work on older firmware, and we should probably test for that (#140).Fixes #127.