Skip to content

update palette to 0.6 - #117

Open
subpop wants to merge 1 commit into
pop-os:masterfrom
subpop:master
Open

update palette to 0.6#117
subpop wants to merge 1 commit into
pop-os:masterfrom
subpop:master

Conversation

@subpop

@subpop subpop commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

Updates palette to 0.6 in the dependency list in Cargo.toml and ports
colors.rs to the 0.6 conversion changes.

Fixes: #115

Updates palette to 0.6 in the dependency list in Cargo.toml and ports
colors.rs to the 0.6 conversion changes.

Signed-off-by: Link Dupont <link@sub-pop.net>
@ids1024

ids1024 commented Dec 27, 2021

Copy link
Copy Markdown
Member

This seems to result in the same hue and saturation numbers displaying a somewhat different color than before.

I'm not entirely sure if that's purely an issue with this PR, or if the code is already kind of wrong in how it handles sRGB vs linear RGB. Or I guess palette was also doing things wrong from this quite in the 0.6 release notes:

They were previously only linear, due to an incorrect assumption, resulting in some situations where they could not give the same result as in other graphics software.

Dealing with linear and non-linear RGB seems to be surprisingly hard to get right and something software often messes up...

@subpop

subpop commented Jan 10, 2022

Copy link
Copy Markdown
Contributor Author

Yea, palette definitely change the way it handles linear RGB. I opened a discussion on the palette discussions while I was trying to figure out how to port this to palette 0.6. Converting to linear is now an explicit additional method call. I am not deeply familiar with how these color encodings work. From my somewhat limited use of the LED coloring on my launch_1, the colors look "the same".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to build from source with palette 0.6

3 participants