Skip to content

fix: use dummy surface to track rectangles - #437

Merged
jacobgkau merged 1 commit into
masterfrom
overlap-dummy-surface
Jun 24, 2026
Merged

fix: use dummy surface to track rectangles#437
jacobgkau merged 1 commit into
masterfrom
overlap-dummy-surface

Conversation

@wash2

@wash2 wash2 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

should fix #434

@wash2
wash2 requested review from a team June 24, 2026 15:22
@jacobgkau jacobgkau self-assigned this Jun 24, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #434. Seems to eliminate the flicker/movement on first launch in addition to subsequent launches. Tested various panel configurations (hidden/larger/on different edges), and it behaves with all of them.

Regression testing passed:

Launcher

  • Cut text from the launcher, then close it; pasting into an app works
  • All windows on all workspaces appear on launch
  • Choosing an app on another workspace moves workspaces and focus to that app
  • Launching an application works
  • Typing text and then removing it will re-show those windows
  • Search works for applications and windows
  • Search works for COSMIC settings panels
  • Open windows are sorted above applications (e.g. "firefox")
  • t: executes a command in a terminal
  • : executes a command in sh
  • = calculates an equation
  • Search results are as expected:
    • cal returns LibreOffice Calc first
    • pops returns Popsicle first
    • shop returns the COSMIC Store first

@jacobgkau
jacobgkau merged commit 811b5bf into master Jun 24, 2026
7 checks passed
@jacobgkau
jacobgkau deleted the overlap-dummy-surface branch June 24, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

excessive jittering/jumping when launcher first opens

3 participants