feat: implement Tab/Shift+Tab navigation and remap autocomplete - #373
Open
cap153 wants to merge 5 commits into
Open
feat: implement Tab/Shift+Tab navigation and remap autocomplete#373cap153 wants to merge 5 commits into
cap153 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements standard keyboard navigation using
TabandShift+Tabto move selection up and down in the launcher list, addressing a common user expectation for GUI launchers.Additionally, the autocomplete functionality (previously bound to
Tab) has been remapped to theRight Arrowkey to prevent conflict and align with shell/terminal behavior.Changes
Navigation Logic:
Tab: Now triggersFocusNext(Select next item).Shift+Tab: Now triggersFocusPrevious(Select previous item).Right Arrow: Now triggersAutocomplete(formerlyTabPress).Refactor:
Message::TabPresstoMessage::Autocomplete. Since the action is no longer bound to the Tab key, this name better reflects the semantic intent.Focus Handling:
Message::KeepFocus.text_input's.on_tab()toMessage::KeepFocus.text_inputwidget captures the Tab key by default. By binding it to a no-op message (KeepFocus), we prevent the widget from consuming the event logic while keeping the input focused, allowing the global subscription to correctly handleTabandShift+Tabevents for navigation.Testing
Tested on Arch Linux by replacing the system binary:
Related Issue
Closes #312