Skip to content

feature/lock screen layout indicator - #501

Open
qqiwi92 wants to merge 2 commits into
pop-os:masterfrom
qqiwi92:feature/lock-screen-layout-indicator
Open

feature/lock screen layout indicator#501
qqiwi92 wants to merge 2 commits into
pop-os:masterfrom
qqiwi92:feature/lock-screen-layout-indicator

Conversation

@qqiwi92

@qqiwi92 qqiwi92 commented Jul 30, 2026

Copy link
Copy Markdown
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.
Kooha-2026-07-30-22-37-27.webm

I have two languages on my system and when entering password, I am always wondering what the active keyboard layout is. So I decided to add a label showing selected language. I have to say that AI was used for searching the optimal solutions and best practices.
Also I've experienced this bug where the language popup was empty and for video demo i had to mock data like this (did not commit mocking):

  let mock_layouts = vec![
                common::ActiveLayout { layout: "us".to_string(), description: "English (US)".to_string(), variant: "".to_string() },
                common::ActiveLayout { layout: "ru".to_string(), description: "Russian".to_string() , variant: "".to_string()},
            ];

So I can't 100% say that this is tested as i could not make just mock get the languages. I also noticed that in locker.rs the same code is being used as in greeter.rs, I thought that this is out of scope of this pr, as there is no logic there, but I can refine that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant