Skip to content

Fix keyboard layout switching in the greeter - #477

Open
FreddyFunk wants to merge 2 commits into
pop-os:masterfrom
FreddyFunk:fix-461-layout-dropdown
Open

Fix keyboard layout switching in the greeter#477
FreddyFunk wants to merge 2 commits into
pop-os:masterfrom
FreddyFunk:fix-461-layout-dropdown

Conversation

@FreddyFunk

Copy link
Copy Markdown
Contributor

Fixes #461
Fixes #360

Super+Space is dispatched by cosmic-comp to com.system76.CosmicSettingsDaemon, which doesn't run in the greeter. So on a fresh boot with no prior login the shortcut hit nothing. The greeter now owns that name and handles the call itself.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant