Avoid endless loading cycle when inputting empty password - #473
Open
fallenwood wants to merge 3 commits into
Open
Avoid endless loading cycle when inputting empty password#473fallenwood wants to merge 3 commits into
fallenwood wants to merge 3 commits into
Conversation
mmstick
reviewed
Jul 29, 2026
| let (socket, _addr) = listener.accept().await.unwrap(); | ||
| println!("new connection"); | ||
|
|
||
| let mut empty_password_reprompted = false; |
Member
There was a problem hiding this comment.
Shouldn't this logic be in cosmic-greeter instead of the example? Is this necessary for the example to check if a password is empty?
Author
There was a problem hiding this comment.
It's used to simulate the real case, because it has different behavior on my fedora devbox when sending empty password for the 1st time and later
Member
|
PR requires to be rebased |
Author
Thanks, I found the issue got regression after resolving conflicts, I'll take another look on it |
Author
|
Done rebasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment: Fedora 44, amd64
Current Behavior: It enters endless loading cycle if the input password is empty, also see #407
New Behavior: It aligns with PAM, if the password is empty,
LLM Usage: