Skip to content

fix: switch to libdav1d for avif in image crate - #141

Merged
wash2 merged 2 commits into
masterfrom
avif
Jul 7, 2026
Merged

fix: switch to libdav1d for avif in image crate#141
wash2 merged 2 commits into
masterfrom
avif

Conversation

@mmstick

@mmstick mmstick commented Jun 29, 2026

Copy link
Copy Markdown
Member

Can test with pop-os/cosmic-settings#2051


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick
mmstick requested review from a team June 29, 2026 22:38

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jammy/binary-amd64 is built on master, but failed on this branch. Do we need to split master_jammy off, or fix the build?

@mmstick

mmstick commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Requires a newer version of libdav1d than jammy has. It's worth not building for jammy

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've branched master_jammy off of master so this won't affect Jammy.

On Noble, this together with pop-os/cosmic-settings#2051 gets AVIF images showing up in Settings, and they appear as expected when selected.

@wash2
wash2 merged commit ed65f7d into master Jul 7, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants