Skip to content

Fix: recursive folder search for slideshows - #139

Open
JuanPBP03 wants to merge 2 commits into
pop-os:masterfrom
JuanPBP03:fix/recursion
Open

Fix: recursive folder search for slideshows#139
JuanPBP03 wants to merge 2 commits into
pop-os:masterfrom
JuanPBP03:fix/recursion

Conversation

@JuanPBP03

@JuanPBP03 JuanPBP03 commented Jun 16, 2026

Copy link
Copy Markdown

Fixes #102. Adds a config file that defaults to a recursive search (since thumbnails are searched recursively too). An additional UI toggle for this setting is in progress.

Also adds a fallback for XDG_DATA_DIRS to comply with XDG spec in case it is not set (as was the case in CachyOS for me) which also blocks the recursive branch.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@nyabinary

Copy link
Copy Markdown

Shouldn't this be in draft status if the UI toggle isn't ready yet?

@jacobgkau

Copy link
Copy Markdown
Member

Shouldn't this be in draft status if the UI toggle isn't ready yet?

Not necessarily. New settings can be added with config file support only, and later added to the GUI if the UX team approves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wallpaper slideshow does not change if images are in a subfolder

3 participants