Fix: recursive folder search for slideshows - #139
Open
JuanPBP03 wants to merge 2 commits into
Open
Conversation
|
Shouldn't this be in draft status if the UI toggle isn't ready yet? |
Member
Not necessarily. New settings can be added with config file support only, and later added to the GUI if the UX team approves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102. Adds a config file that defaults to a recursive search (since thumbnails are searched recursively too). An additional UI toggle for this setting is in progress.
Also adds a fallback for XDG_DATA_DIRS to comply with XDG spec in case it is not set (as was the case in CachyOS for me) which also blocks the recursive branch.