Chjange min version

poolsideai · Nov 30, 2024 · 63d8db7 · 63d8db7
1 parent 84098e6
commit 63d8db7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 30 deletions.
diff --git a/.github/workflows/wheel.yml b/.github/workflows/wheel.yml
@@ -13,7 +13,7 @@ jobs:
   build_wheels:
     strategy:
       matrix:
-        os: [ubuntu-latest, macOS-14]
+        os: [ubuntu-latest, macOS-latest, macOS-14]
     runs-on: ${{ matrix.os }}
     name: Build wheels on ${{ matrix.os }}
 
@@ -62,7 +62,7 @@ jobs:
           cmake -B ${{github.workspace}}/build -DSPM_ENABLE_SHARED=OFF -DCMAKE_INSTALL_PREFIX=${{github.workspace}}/build/root
           cmake --build ${{github.workspace}}/build --config Release --target install --parallel 8
         env:
-          CMAKE_OSX_ARCHITECTURES: arm64;x86_64
+          CMAKE_OSX_ARCHITECTURES: arm64
 
       - name: Build wheels
         working-directory: ${{github.workspace}}/python
@@ -74,35 +74,8 @@ jobs:
           CIBW_ARCHS_MACOS: arm64
           CIBW_SKIP: "pp* *-musllinux_*"
           CIBW_BUILD_VERBOSITY: 1
-
-      # - name: Build sdist archive
-      #   working-directory: ${{github.workspace}}/python
-      #   run: sh build_sdist.sh
-
-      # - name: Fetch sdist archive
-      #   uses: tj-actions/glob@2944188f585a0ec102a6a82d9eeb3aed69785393 # v22.0.1
-      #   id: sdist
-      #   with:
-      #     files: ./python/dist/*.tar.gz
-
-      # - name: Build wheel from sdist
-      #   run: python3 -m pip wheel "${{ steps.sdist.outputs.paths }}" --wheel-dir=${{env.WHEEL_DST}} --verbose
-
-
-      # - name: Authenticate with AWS CodeArtifact
-      #   run: |
-      #     CODEARTIFACT_AUTH_TOKEN=$(aws codeartifact get-authorization-token --domain ${{env.DOMAIN}} --query authorizationToken --output text)
-      #     echo "[distutils]" > ~/.pypirc
-      #     echo "index-servers = codeartifact" >> ~/.pypirc
-      #     echo "[codeartifact]" >> ~/.pypirc
-      #     echo "repository: ${{ env.REPOSITORY }}" >> ~/.pypirc
-      #     echo "username: aws" >> ~/.pypirc
-      #     echo "password: ${CODEARTIFACT_AUTH_TOKEN}" >> ~/.pypirc
 
       - name: Publish
         run: |
-          # export TWINE_USERNAME=aws
-          # export TWINE_PASSWORD=`aws codeartifact get-authorization-token --domain ${{env.DOMAIN}} --query authorizationToken --output text`
-          # export TWINE_REPOSITORY_URL=`aws codeartifact get-repository-endpoint --domain ${{env.DOMAIN}} --repository ${{ env.REPOSITORY }}  --region us-east-1 --format pypi --query repositoryEndpoint --output text`
           aws codeartifact login --tool twine --domain ${{env.DOMAIN}} --repository ${{ env.REPOSITORY }}
           twine upload --verbose --repository codeartifact ${{env.WHEEL_DST}}/*.whl
diff --git a/python/setup.py b/python/setup.py
@@ -91,7 +91,7 @@ def build_extension(self, ext):
     # Fix compile on some versions of Mac OSX
     # See: https://github.com/neulab/xnmt/issues/199
     if sys.platform == 'darwin':
-      cflags.append('-mmacosx-version-min=10.9')
+      cflags.append('-mmacosx-version-min=14.0')
     else:
       cflags.append('-Wl,-strip-all')
       libs.append('-Wl,-strip-all')