Skip to content

Add missing tf.function parameters #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Add missing tf.function parameters #142

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5bfb831
adding two missing params
Jan 24, 2023
0f84bb0
fix trailing whitespace
Jan 24, 2023
8872d38
Merge remote-tracking branch 'upstream/main' into 139-missing-tffunct…
Jan 26, 2023
fe4a4f0
Progress
Jan 26, 2023
b13b3d2
Fix
Jan 26, 2023
700d3bf
Merge branch 'main' into 139-missing-tffunction-parameters
Jan 31, 2023
3ca358f
Maintaining the same format
Feb 26, 2023
e659e93
Formatting, trailing whitespace
Feb 26, 2023
3f284f1
Maintaining the same format
Feb 26, 2023
f587254
Passing build
Feb 27, 2023
35fd7a7
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 4, 2023
52e25b8
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 5, 2023
fee0cbc
Adding more information
Mar 6, 2023
8f79e34
Adding more information
Mar 6, 2023
2215e1f
Restructure sentence
Mar 8, 2023
f4047bf
Restructure sentence
Mar 8, 2023
cbfd513
Adding additional information to field description (link included)
Mar 15, 2023
20b4418
Merge branch 'main' into 139-missing-tffunction-parameters
Mar 15, 2023
ce615bb
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 21, 2023
3ffd5a9
Adding specific URLs
Mar 22, 2023
617cfb5
removing HTML
Mar 22, 2023
c9a3be5
Merge branch 'main' into 139-missing-tffunction-parameters
khatchad Mar 28, 2023
98a669e
Merge branch 'main' into 139-missing-tffunction-parameters
Mar 31, 2023
0d64c55
matching anchor with field name
Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/analysis/Function.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,15 @@ public class HybridizationParameters {
private boolean inputSignatureParamExists;

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter jit_compile.
* True iff this {@link Function}'s {@link decoratorsType} has parameter jit_compile and deprecated name experimental_compile. For
* more information, you can see this <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>.
*/
private boolean jitCompileParamExists;

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter reduce_retracing.
* True iff this {@link Function}'s {@link decoratorsType} has parameter reduce_retracing and deprecated name
* experimental_relax_shapes. For more information, you can see this
* <a href="https://www.tensorflow.org/versions/r2.9/api_docs/python/tf/function">URL</a>.
Copy link
Member

@khatchad khatchad Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the URL is fine; we don't need HTML. I still don't see the HTML anchor reference to the specific field.

Copy link
Author

@tatianacv tatianacv Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it.

*/
private boolean reduceRetracingParamExists;

Expand Down Expand Up @@ -240,6 +243,29 @@ public boolean hasJitCompileParam() {
public boolean hasReduceRetracingParam() {
return this.reduceRetracingParamExists;
}

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_compile.
*
* @return True iff this {@link Function} has parameter experimental_compile.
*/
public boolean hasExperimentalCompileParam() {
// Since jit_compile and experimental_compile (deprecated) have the same functionalities, when we parse these parameters
// together and store it into the same boolean variable.
return this.jitCompileParamExists;
}

/**
* True iff this {@link Function}'s {@link decoratorsType} has parameter experimental_relax_shapes.
*
* @return True iff this {@link Function} has parameter experimental_relax_shapes.
*/
public boolean hasExperimentalRelaxShapesParam() {
// Since reduce_retracing and experimental_relax_shapes (deprecated) have the same functionalities, when we parse these
// parameters together and store it into the same boolean variable.
return this.reduceRetracingParamExists;
}

}

private static final String TF_FUNCTION_FQN = "tensorflow.python.eager.def_function.function";
Expand Down
11 changes: 11 additions & 0 deletions ...ze.tests/test cases/edu/cuny/hunter/hybridize/tests/HybridizeFunctionRefactoringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,7 @@ public void testComputeParameters() throws Exception {

assertTrue(!args.hasFuncParam() && args.hasInputSignatureParam() & !args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -608,6 +609,7 @@ public void testComputeParameters2() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & !args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -629,6 +631,7 @@ public void testComputeParameters3() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & !args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -650,6 +653,7 @@ public void testComputeParameters4() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & !args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -671,6 +675,7 @@ public void testComputeParameters5() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & !args.hasAutoGraphParam() && args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -690,6 +695,7 @@ public void testComputeParameters6() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & !args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -711,6 +717,7 @@ public void testComputeParameters7() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -732,6 +739,7 @@ public void testComputeParameters8() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & !args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand All @@ -753,6 +761,7 @@ public void testComputeParameters9() throws Exception {

assertTrue(!args.hasFuncParam() && args.hasInputSignatureParam() & args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());
}

Expand Down Expand Up @@ -800,6 +809,7 @@ public void testComputeParameters11() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & args.hasAutoGraphParam() && !args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && !args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());

}
Expand All @@ -822,6 +832,7 @@ public void testComputeParameters12() throws Exception {

assertTrue(!args.hasFuncParam() && !args.hasInputSignatureParam() & !args.hasAutoGraphParam() && args.hasJitCompileParam()
&& !args.hasReduceRetracingParam() && !args.hasExperimentalImplementsParam() && !args.hasExperimentalAutographOptParam()
&& !args.hasExperimentalRelaxShapesParam() && args.hasExperimentalCompileParam()
&& !args.hasExperimentalFollowTypeHintsParam());

}
Expand Down