ci: rework test/lint workflow #545
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjenkins
force-pushed
the
kenjenkins/windows-ci
branch
from
5431220 to
10a2d3b
Compare
kenjenkins
force-pushed
the
kenjenkins/windows-ci
branch
from
ca4bdfb to
2548fca
Compare
The setup-go action has default caching that relies on the go.sum file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rework the test/lint workflow: move the lint step into the precommit check, and configure the test job to run on Windows in addition to Linux.
Remove the Go binary caching step as this is likely not helpful. Use the default shallow checkout rather than fetching the entire repo history.
Related issues
https://linear.app/pomerium/issue/ENG-2587/cli-set-up-ci-builds-of-windows-macos-binaries-per-pr
Checklist
improvement/bug/ etc)