h5pp works in cpp20 by killing off use of fmt #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teseoch
reviewed
Aug 20, 2024
CMakeLists.txt
Outdated
| @@ -66,7 +66,7 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/recipes/") | |||
|
|
|||
| # Set default minimum C++ standard | |||
| if(PARAVIEWO_TOPLEVEL_PROJECT) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
| set(CMAKE_CXX_STANDARD 20) | |||
There was a problem hiding this comment.
eh, it was useful for making sure paraviewo was built in cpp20 - we could do this cleaner i guess (by only assigning it to the single paraviewo target), but it's a minor detail
| @@ -8,8 +8,9 @@ endif() | |||
| message(STATUS "Third-party: creating target 'h5pp'") | |||
|
|
|||
| SET(H5PP_ENABLE_EIGEN3 ON) | |||
| SET(H5PP_ENABLE_FMT ON) | |||
| SET(H5PP_ENABLE_FMT OFF) | |||
There was a problem hiding this comment.
if this is not required anymore, can we drop the fmt cmake recipe and include?
There was a problem hiding this comment.
fmt is theoretically required downstream - it would be good to keep the recipe in the wildmeshing repo perhaps? I got the habit of manually packaging fmt when i used spdlog from before fmt::join was in not in the fmt version packaged with spdlog - using the spdlog packaged version of fmt always felt a bit awkward in general :(.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.